[ https://issues.apache.org/jira/browse/HADOOP-18283?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Steve Loughran updated HADOOP-18283: ------------------------------------ Description: Need to review S3A prefetching stream retry logic * no attempt to retry on unrecoverable errors * do try on recoverable ones * no wrap of retry by retry. * annotate classes with Retries annotations to aid the review. a key concern has to be that transient failure of prefetch is recovered from; things like deleted/shortened file fails properly on the next read call the other issue is: review all thread safety. the outer stream appears thread safe, so review to make sure that is sufficient was: Need to review S3A prefetching stream retry logic * no attempt to retry on unrecoverable errors * do try on recoverable ones * no wrap of retry by retry. * annotate classes with Retries annotations to aid the review. a key concern has to be that transient failure of prefetch is recovered from; things like deleted/shortened file fails properly on the next read call > Review s3a prefetching input stream retry code; synchronization > --------------------------------------------------------------- > > Key: HADOOP-18283 > URL: https://issues.apache.org/jira/browse/HADOOP-18283 > Project: Hadoop Common > Issue Type: Sub-task > Components: fs/s3 > Affects Versions: 3.4.0 > Reporter: Steve Loughran > Priority: Major > > Need to review S3A prefetching stream retry logic > * no attempt to retry on unrecoverable errors > * do try on recoverable ones > * no wrap of retry by retry. > * annotate classes with Retries annotations to aid the review. > a key concern has to be that transient failure of prefetch is recovered > from; things like deleted/shortened file fails properly on the next read call > the other issue is: review all thread safety. the outer stream appears thread > safe, so review to make sure that is sufficient -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org