[ https://issues.apache.org/jira/browse/HADOOP-8121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13222630#comment-13222630 ]
Aaron T. Myers commented on HADOOP-8121: ---------------------------------------- Thanks for checking on that, Natty. A few more comments/questions: # Seems like we could cache the SearchControls object as well. Looks to me like it could even just be statically initialized. # I think createDirContext should be renamed getDirContext, as it's not necessarily creating a new DirContext each time it's called. # There's what looks to be a potential race in initializing the DirContext, since you check for null and then initialize without holding any lock, though it may not matter at all. # Since the DirContext is now long-lived, what happens if a connection to the LDAP server breaks? Will this class automatically re-connect? (Is that even the right term?) > Active Directory Group Mapping Service > -------------------------------------- > > Key: HADOOP-8121 > URL: https://issues.apache.org/jira/browse/HADOOP-8121 > Project: Hadoop Common > Issue Type: New Feature > Components: security > Reporter: Jonathan Natkins > Assignee: Jonathan Natkins > Attachments: HADOOP-8121.2.patch, HADOOP-8121.3.patch, > HADOOP-8121.4.patch, HADOOP-8121.5.patch, HADOOP-8121.6.patch, > HADOOP-8121.patch > > > Planning on building a group mapping service that will go and talk directly > to an Active Directory setup to get group memberships -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira