LiuGuH commented on PR #5642: URL: https://github.com/apache/hadoop/pull/5642#issuecomment-1545058013
> [HDFS-15086](https://issues.apache.org/jira/browse/HDFS-15086) changed storedBlock to blockInfo without any specific reason. > > > (1) It does not stop PendingReconstructionMonitor. The blockid will into timeouts queue because of timout duration is 3s. > > I don't catch this, can you elaborate, what will fail? Does putting a sleep of more than 3 seconds anywhere in the test lead to failures if this isn't there, if yes, can you tell me where to put that, so that I can try locally GenericTestUtils.waitFor(() -> pendingReconstruction.size() == 0, 500, 10000); // The pending queue should be empty. assertEquals("Size of pendingReconstructions ", 0, pendingReconstruction.size()); } finally { if (cluster != null) { cluster.shutdown(); } } GenericTestUtils.waitFor() will sleep maximum 10s. The pendingReconstruction will timeout after 3s ，then will be into timeout list. PendingReconstructionMonitor will not be stoped if I change GenericTestUtils.waitFor to 1s . -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
