Hexiaoqiao commented on code in PR #5353: URL: https://github.com/apache/hadoop/pull/5353#discussion_r1198896990
########## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/ReplicaMap.java: ########## @@ -178,13 +178,13 @@ void mergeAll(ReplicaMap other) { for (ReplicaInfo replicaInfo : replicaInfos) { replicaSet.add(replicaInfo); } + if (curSet == null) { Review Comment: This condition should be following here, ``` if (curSet == null && !replicaSet.isEmpty()) { // Add an entry for block pool if it does not exist already curSet = new LightWeightResizableGSet<>(); map.put(bp, curSet); } ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org