Hexiaoqiao commented on code in PR #5561: URL: https://github.com/apache/hadoop/pull/5561#discussion_r1199749665
########## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirConcatOp.java: ########## @@ -121,7 +121,7 @@ private static INodeFile[] verifySrcFiles(FSDirectory fsd, String[] srcs, for(String src : srcs) { final INodesInPath iip = fsd.resolvePath(pc, src, DirOp.WRITE); // permission check for srcs - if (pc != null) { + if (fsd.isPermissionEnabled()) { Review Comment: `if (fsd.isPermissionEnabled())` should be `if (pc != null && fsd.isPermissionEnabled())` here? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org