K0K0V0K commented on code in PR #3618:
URL: https://github.com/apache/hadoop/pull/3618#discussion_r1200291957


##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/TestContainerAllocation.java:
##########
@@ -1392,4 +1412,15 @@ public void 
testContainerRejectionWhenAskBeyondDynamicMax()
 
     rm1.close();
   }
+
+  private CapacityScheduler getCapacityScheduler(MockRM rm1, int memoryGb) {

Review Comment:
   I renamed the method to setupCapacitySchedulerI



##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/TestContainerAllocation.java:
##########
@@ -169,6 +172,7 @@ public void testContainerTokenGeneratedOnPullRequest() 
throws Exception {
     MockRM rm1 = new MockRM(conf);
     rm1.start();
     MockNM nm1 = rm1.registerNode("127.0.0.1:1234", 8000);
+    CapacityScheduler cs = getCapacityScheduler(rm1, 8);

Review Comment:
   done



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

Reply via email to