[GitHub] [hadoop] ZanderXu commented on a diff in pull request #5671: HDFS-17019. Optimize the logic for reconfigure slow peer enable for Namenode"

[via GitHub]

ZanderXu commented on code in PR #5671:
URL: https://github.com/apache/hadoop/pull/5671#discussion_r1201570774


##########
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/DatanodeManager.java:
##########
@@ -376,10 +373,14 @@ public void initSlowPeerTracker(Configuration conf, Timer 
timer,
     this.slowPeerTracker = dataNodePeerStatsEnabled ?
         new SlowPeerTracker(conf, timer) :
         new SlowPeerDisabledTracker(conf, timer);
+    if (slowPeerTracker.isSlowPeerTrackerEnabled()) {
+      startSlowPeerCollector();
+    }

Review Comment:
   should we stop the running thread if 
`slowPeerTracker.isSlowPeerTrackerEnabled()` return `false`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org