goiri commented on code in PR #5638:
URL: https://github.com/apache/hadoop/pull/5638#discussion_r1204408155
##########
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/curator/ZKCuratorManager.java:
##########
@@ -34,31 +39,32 @@
import org.apache.hadoop.fs.CommonConfigurationKeys;
import org.apache.hadoop.security.SecurityUtil;
import org.apache.hadoop.security.authentication.util.JaasConfiguration;
+import org.apache.hadoop.util.Preconditions;
import org.apache.hadoop.util.ZKUtil;
import org.apache.zookeeper.CreateMode;
import org.apache.zookeeper.Watcher;
import org.apache.zookeeper.ZooKeeper;
import org.apache.zookeeper.client.ZKClientConfig;
+import org.apache.zookeeper.common.ClientX509Util;
import org.apache.zookeeper.data.ACL;
import org.apache.zookeeper.data.Stat;
-import org.slf4j.Logger;
-import org.slf4j.LoggerFactory;
-
-import org.apache.hadoop.util.Preconditions;
/**
* Helper class that provides utility methods specific to ZK operations.
*/
@InterfaceAudience.Private
public final class ZKCuratorManager {
- private static final Logger LOG =
- LoggerFactory.getLogger(ZKCuratorManager.class);
+ private static final Logger LOG =
LoggerFactory.getLogger(ZKCuratorManager.class);
Review Comment:
I like cleaning this kind of things but it adds too much churn for a change
that should be more contained.
I would prefer having a PR just for cleaning up the code than adding some
feature while fixing other things in the side.
Let's avoid in this PR:
* Changing import.
* Adjusting line length breaks.
* Adjusting comments.
* Changing order.
Happy to review the followup for those.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
