goiri commented on code in PR #5691: URL: https://github.com/apache/hadoop/pull/5691#discussion_r1209486359
########## hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/NamenodeHeartbeatService.java: ########## @@ -482,17 +502,35 @@ private void updateHAStatusParameters(NamenodeStatusReport report) { } } + /** + * Evaluates whether the JMX report should be refreshed by + * calling the Namenode, based on the following conditions: + * 1. JMX Updates must be enabled. + * 2. The last attempt to update JMX occurred before the + * configured interval (if any). + */ + private boolean shouldUpdateJmx() { + return this.updateJmxIntervalMs >= 0 Review Comment: Might be cleaner to read as: ``` if (this.updateJmxIntervalMs == 0) return false; } return Time.monotonicNow() - this.lastJmxUpdateAttempt > this.updateJmxIntervalMs ``` ########## hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/NamenodeHeartbeatService.java: ########## @@ -482,17 +502,35 @@ private void updateHAStatusParameters(NamenodeStatusReport report) { } } + /** + * Evaluates whether the JMX report should be refreshed by + * calling the Namenode, based on the following conditions: + * 1. JMX Updates must be enabled. + * 2. The last attempt to update JMX occurred before the + * configured interval (if any). + */ + private boolean shouldUpdateJmx() { + return this.updateJmxIntervalMs >= 0 Review Comment: Or < 0. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org