NishthaShah commented on code in PR #5696: URL: https://github.com/apache/hadoop/pull/5696#discussion_r1209635689
########## hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/metrics/RBFMetrics.java: ########## @@ -50,6 +50,8 @@ import javax.management.ObjectName; import javax.management.StandardMBean; +import com.fasterxml.jackson.core.JsonProcessingException; Review Comment: @goiri I had to use fasterxml to fix the main issue - to return a string, I think alternatively we can also use StringBuilder/StringJoiner if using fasterxml is not the desired way here. Two more places where I see similar usage is SlowDiskTracker and SlowPeerTracker -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
