hfutatzhanghb commented on code in PR #5694: URL: https://github.com/apache/hadoop/pull/5694#discussion_r1209644808
########## hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/ConnectionContext.java: ########## @@ -150,8 +150,8 @@ public synchronized void close(boolean force) { // this is an erroneous case, but we have to close the connection // anyway since there will be connection leak if we don't do so // the connection has been moved out of the pool - LOG.error("Active connection with {} handlers will be closed", - this.numThreads); + LOG.error("Active connection with {} handlers will be closed, ConnectionContext is {}", + this.numThreads, this.toString()); Review Comment: > Can you also show an example of what this would look like? Sir, I did not find this error log in our cluster. I just think we should log connection information here when some error occurs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org