goiri commented on code in PR #5705: URL: https://github.com/apache/hadoop/pull/5705#discussion_r1212058864
########## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/amrmproxy/FederationInterceptor.java: ########## @@ -590,18 +590,9 @@ private Map<String, Token<AMRMTokenIdentifier>> recoverSubClusterAMRMTokenIdenti // Save the registration request. This will be used for registering with // secondary sub-clusters using UAMs, as well as re-register later this.amRegistrationRequest = request; - if (getNMStateStore() != null) { - try { - RegisterApplicationMasterRequestPBImpl pb = - (RegisterApplicationMasterRequestPBImpl) - this.amRegistrationRequest; - getNMStateStore().storeAMRMProxyAppContextEntry(this.attemptId, - NMSS_REG_REQUEST_KEY, pb.getProto().toByteArray()); - } catch (Exception e) { - LOG.error("Error storing AMRMProxy application context entry for " - + this.attemptId, e); - } - } + RegisterApplicationMasterRequestPBImpl requestPB = (RegisterApplicationMasterRequestPBImpl) Review Comment: How are we sure this is all initialized now? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org