ayushtkn commented on code in PR #5698:
URL: https://github.com/apache/hadoop/pull/5698#discussion_r1213973691
##########
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/web/TestWebHDFS.java:
##########
@@ -2291,6 +2291,36 @@ public void testFsStatus() throws Exception {
}
}
+ @Test
+ public void testGetErasureCodingPolicies() throws Exception {
+ final Configuration conf = WebHdfsTestUtil.createConf();
+ try {
+ cluster = new MiniDFSCluster.Builder(conf).build();
+ cluster.waitActive();
+
+ final WebHdfsFileSystem webHdfs =
+ WebHdfsTestUtil.getWebHdfsFileSystem(conf,
+ WebHdfsConstants.WEBHDFS_SCHEME);
+
+ final DistributedFileSystem dfs = cluster.getFileSystem();
+
+ Collection<ErasureCodingPolicyInfo> webHdfsEcPolicyInfos =
+ webHdfs.getAllErasureCodingPolicies();
+
+ Collection<ErasureCodingPolicyInfo> dfsEcPolicyInfos =
+ dfs.getAllErasureCodingPolicies();
+
+ //Validate erasureCodingPolicyInfos are the same as DistributedFileSystem
+ boolean isEqual = webHdfsEcPolicyInfos.stream()
+ .allMatch(dfsEcPolicyInfos::contains) &&
+ dfsEcPolicyInfos.stream()
+ .allMatch(webHdfsEcPolicyInfos::contains);
+ assertTrue(isEqual);
Review Comment:
Can we do this instead
```
//Validate erasureCodingPolicyInfos are the same as
DistributedFileSystem
assertEquals(dfsEcPolicyInfos.size(), webHdfsEcPolicyInfos.size());
assertTrue(dfsEcPolicyInfos.containsAll(webHdfsEcPolicyInfos));
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
