mehakmeet commented on code in PR #5519:
URL: https://github.com/apache/hadoop/pull/5519#discussion_r1222648403
##########
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/lib/output/committer/manifest/impl/EntryFileIO.java:
##########
@@ -63,7 +63,18 @@ public class EntryFileIO {
private static final Logger LOG = LoggerFactory.getLogger(
EntryFileIO.class);
- public static final int WRITER_SHUTDOWN_TIMEOUT = 60;
+ /**
+ * How long should the writer shutdown take?
+ */
+ public static final int WRITER_SHUTDOWN_TIMEOUT_SECONDS = 60;
+
+ /**
+ * How long should trying to queue a write block before giving up
+ * with an error?
+ * This is a safety feature to ensure that if something has gone wrong
+ * in the queue code the job fails with an error rather than just hangs
+ */
+ public static final int WRITER_QUEUE_PUT_TIMEOUT_MINUTES = 10;
Review Comment:
Sorry, I think I missed these constants being added, don't you think these
should be configurable, just for some kind of fallback sakes, so that these
values never cause any issues and are easily changeable? I guess if it waits
for this long then, we can assume it's just hanging as well. Your call on it
being configurable or not.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
