steveloughran commented on code in PR #5718:
URL: https://github.com/apache/hadoop/pull/5718#discussion_r1223339252
##########
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/impl/prefetch/SingleFilePerBlockCache.java:
##########
@@ -333,37 +335,33 @@ protected Path getCacheFilePath(final Configuration conf,
@Override
public void close() throws IOException {
- if (closed) {
- return;
- }
-
- closed = true;
+ if (closed.compareAndSet(false, true)) {
+ LOG.info(getStats());
Review Comment:
could we log this at debug; prefetching is fairly noisy right now
##########
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/impl/prefetch/SingleFilePerBlockCache.java:
##########
@@ -258,27 +260,23 @@ protected Path getCacheFilePath(final Configuration conf,
@Override
public void close() throws IOException {
- if (closed) {
- return;
- }
-
- closed = true;
-
- LOG.info(getStats());
- int numFilesDeleted = 0;
-
- for (Entry entry : blocks.values()) {
- try {
- Files.deleteIfExists(entry.path);
- prefetchingStatistics.blockRemovedFromFileCache();
- numFilesDeleted++;
- } catch (IOException e) {
- LOG.debug("Failed to delete cache file {}", entry.path, e);
+ if (closed.compareAndSet(false, true)) {
+ LOG.info(getStats());
+ int numFilesDeleted = 0;
+
+ for (Entry entry : blocks.values()) {
+ try {
+ Files.deleteIfExists(entry.path);
+ prefetchingStatistics.blockRemovedFromFileCache();
+ numFilesDeleted++;
+ } catch (IOException e) {
+ LOG.debug("Failed to delete cache file {}", entry.path, e);
+ }
}
- }
- if (numFilesDeleted > 0) {
- LOG.info("Deleted {} cache files", numFilesDeleted);
+ if (numFilesDeleted > 0) {
+ LOG.info("Deleted {} cache files", numFilesDeleted);
Review Comment:
downgrade to debug and remove the if() test; we can log the zero count too
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
