ayushtkn commented on code in PR #5696:
URL: https://github.com/apache/hadoop/pull/5696#discussion_r1224038596
##########
hadoop-hdfs-project/hadoop-hdfs-rbf/src/test/java/org/apache/hadoop/hdfs/server/federation/security/TestRouterSecurityManager.java:
##########
@@ -259,6 +272,39 @@ private static String[] getUserGroupForTesting() {
return groupsForTesting;
}
+ @Test
+ public void testGetTopTokenRealOwners() throws Exception {
+ // Create conf and start routers with only an RPC service
+ Configuration conf = initSecurity();
+
+ Configuration routerConf = new RouterConfigBuilder()
+ .metrics()
+ .rpc()
+ .build();
+ conf.addResource(routerConf);
+
+ Router router = initializeAndStartRouter(conf);
+
+ // Create credentials
+ UserGroupInformation ugi =
UserGroupInformation.createUserForTesting("router", getUserGroupForTesting());
+ Credentials creds = RouterSecurityManager.createCredentials(router, ugi,
"some_renewer");
Review Comment:
only doing this
```
RouterSecurityManager.createCredentials(router, ugi, "some_renewer");
```
instead of
```
Credentials creds = RouterSecurityManager.createCredentials(router, ugi,
"some_renewer");
```
creates issues, it is just not assigning to creds, because we don't use
``creds`` variable anywhere
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
