xinglin commented on code in PR #5730:
URL: https://github.com/apache/hadoop/pull/5730#discussion_r1228448128
##########
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java:
##########
@@ -600,17 +600,18 @@ void logSlowRpcCalls(String methodName, Call call,
}
}
- void updateMetrics(Call call, long startTime, boolean connDropped) {
+ void updateMetrics(Call call, long processingStartTime, boolean connDropped)
{
totalRequests.increment();
// delta = handler + processing + response
- long deltaNanos = Time.monotonicNowNanos() - startTime;
- long timestampNanos = call.timestampNanos;
+ long completionTime = Time.monotonicNowNanos();
+ long deltaNanos = completionTime - processingStartTime;
+ long arrivalTime = call.timestampNanos;
ProcessingDetails details = call.getProcessingDetails();
// queue time is the delta between when the call first arrived and when it
// began being serviced, minus the time it took to be put into the queue
details.set(Timing.QUEUE,
Review Comment:
after appending "Nanos" to both ProcessingStartTime and arrivalTime, we no
longer fit in one line. leave it as it is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
