Hexiaoqiao commented on PR #5743: URL: https://github.com/apache/hadoop/pull/5743#issuecomment-1595672568
Back to this PR. Considering that blockId/blockGroupId generator is protected by global lock, I think we do not need more `synchronized` protection which has some time cost. However we should add some more explicit annotation to note that `SequentialBlockGroupIdGenerator` is not thread-safe class. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
