xinglin commented on code in PR #5803: URL: https://github.com/apache/hadoop/pull/5803#discussion_r1258972944
########## hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/server/namenode/ha/ObserverReadProxyProvider.java: ########## @@ -648,6 +645,7 @@ public synchronized void close() throws IOException { } } failoverProxy.close(); + nnProbingThreadPool.shutdown(); Review Comment: According to this post, it would be called when the garbage collector is reclaiming that object. When that would happen is out of control from programmers. https://stackoverflow.com/questions/18670658/why-close-cannot-be-called-on-closeable-classes-automatically -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org