[ https://issues.apache.org/jira/browse/HADOOP-18807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17744706#comment-17744706 ]
ASF GitHub Bot commented on HADOOP-18807: ----------------------------------------- steveloughran commented on code in PR #5847: URL: https://github.com/apache/hadoop/pull/5847#discussion_r1268331301 ########## hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/fs/viewfs/TestViewFileSystemClose.java: ########## @@ -0,0 +1,64 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.hadoop.fs.viewfs; Review Comment: oh, ok. > Close child file systems in ViewFileSystem when cache is disabled. > ------------------------------------------------------------------ > > Key: HADOOP-18807 > URL: https://issues.apache.org/jira/browse/HADOOP-18807 > Project: Hadoop Common > Issue Type: Bug > Reporter: Shuyan Zhang > Priority: Major > Labels: pull-request-available > > When the cache is configured to disabled (namely, > `fs.viewfs.enable.inner.cache=false` and `fs.*.impl.disable.cache=true`), > even if `FileSystem.close()` is called, the client cannot truly close the > child file systems in a ViewFileSystem. This caused our long-running clients > to constantly produce resource leaks. -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org