brumi1024 commented on code in PR #5871:
URL: https://github.com/apache/hadoop/pull/5871#discussion_r1273195384
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/AbstractCSQueue.java:
##########
@@ -463,12 +463,14 @@ protected void setDynamicQueueProperties() {
queueContext.getQueueManager().getConfiguredNodeLabelsForAllQueues()
.setLabelsByQueue(getQueuePath(), new
HashSet<>(parentNodeLabels));
}
+ Map<String, QueueCapacityVector> templateConfiguredResourceVector =
queueContext.getConfiguration()
+ .parseConfiguredResourceVector(queuePath.getFullPath(),
parentNodeLabels);
+
Review Comment:
This is just for validating if the template contained resource vectors,
because we need to set weight to 1 if not. The issue here was that we already
parsed the capacity vectors we just simply overrode them with
"queueContext.getConfiguration().setLabeledQueueWeight(queuePath.getFullPath(),
label, 1);"
But I've refactored this, as we don't need to iterate through the node
labels this many times.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
