[ https://issues.apache.org/jira/browse/HADOOP-4885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13229929#comment-13229929 ]
Eli Collins commented on HADOOP-4885: ------------------------------------- bq. The format-addStorageDir solution make the failed directory "active" immediately even it's not a real active state. The state is visible from the nn UI and JMX. If the checkpoint fails, the fake "Active" state can be misleading. Not sure I'm following.. when you roll the log and it restores the storage directory it creates a new empty storage dir, the directory is added to the list of storage dirs and a new edit log is immediately created on it (see FSEditLog#rollEditLog), ie it is immediately "active" right? Have you done any testing of this patch aside from running the unit tests? > Try to restore failed replicas of Name Node storage (at checkpoint time) > ------------------------------------------------------------------------ > > Key: HADOOP-4885 > URL: https://issues.apache.org/jira/browse/HADOOP-4885 > Project: Hadoop Common > Issue Type: Improvement > Reporter: Boris Shkolnik > Assignee: Boris Shkolnik > Fix For: 0.21.0 > > Attachments: HADOOP-4885-1.patch, HADOOP-4885-3.patch, > HADOOP-4885-3.patch, HADOOP-4885.branch-1.patch, > HADOOP-4885.branch-1.patch.2, HADOOP-4885.branch-1.patch.3, > HADOOP-4885.patch, HADOOP-4885.patch > > -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira