Hexiaoqiao commented on code in PR #5924: URL: https://github.com/apache/hadoop/pull/5924#discussion_r1286718143
########## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/BPOfferService.java: ########## @@ -291,9 +291,8 @@ public String toString() { void reportBadBlocks(ExtendedBlock block, String storageUuid, StorageType storageType) { checkBlock(block); + ReportBadBlockAction rbbAction = new ReportBadBlockAction(block, storageUuid, storageType); Review Comment: I am not worried about that, because `BPOfferService` is isolated for different namespaces. But I am wonder what improvement here, save the cost to create object and heap footprint? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org