[ https://issues.apache.org/jira/browse/HADOOP-18820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17752452#comment-17752452 ]
ASF GitHub Bot commented on HADOOP-18820: ----------------------------------------- steveloughran commented on code in PR #5872: URL: https://github.com/apache/hadoop/pull/5872#discussion_r1288761982 ########## hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/S3AUtils.java: ########## @@ -562,15 +563,65 @@ public static long dateToLong(final Date date) { * @return instance of the specified class * @throws IOException on any problem */ - @SuppressWarnings("unchecked") - public static <InstanceT> InstanceT getInstanceFromReflection(Class<?> instanceClass, - Configuration conf, @Nullable URI uri, Class<?> interfaceImplemented, String methodName, + public static <InstanceT> InstanceT getInstanceFromReflection( Review Comment: done > AWS SDK v2: make the v1 bridging support optional > ------------------------------------------------- > > Key: HADOOP-18820 > URL: https://issues.apache.org/jira/browse/HADOOP-18820 > Project: Hadoop Common > Issue Type: Sub-task > Components: fs/s3 > Affects Versions: 3.4.0 > Reporter: Steve Loughran > Assignee: Steve Loughran > Priority: Major > Labels: pull-request-available > > The AWS SDK v2 code includes the v1 sdk core for plugin support of > * existing credential providers > * delegation token binding > I propose we break #2 and rely on those who have implemented to to upgrade. > apart from all the needless changes the v2 SDK did to the api (why?) this is > fairly straighforward > for #1: fix through reflection, retaining a v1 sdk dependency at test time so > we can verify that the binder works. -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org