Tre2878 commented on code in PR #5855:
URL: https://github.com/apache/hadoop/pull/5855#discussion_r1294232811
##########
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockManager.java:
##########
@@ -2957,6 +2957,22 @@ public boolean processReport(final DatanodeID nodeID,
return !node.hasStaleStorages();
}
+ /**
+ * Remove the DN lease only when we have received block reports,
+ * for all storages for a particular DN.
+ */
+ void removeDNLeaseIfNeeded(DatanodeDescriptor node) {
+ boolean needRemoveLease = true;
+ for (DatanodeStorageInfo sInfo : node.getStorageInfos()) {
+ if (sInfo.getBlockReportCount() == 0) {
+ needRemoveLease = false;
Review Comment:
Yes, I do. Let me add it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
