flaming-archer commented on code in PR #5959: URL: https://github.com/apache/hadoop/pull/5959#discussion_r1299291294
########## hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/store/StateStoreService.java: ########## @@ -64,6 +64,12 @@ * <li>File {@link * org.apache.hadoop.hdfs.server.federation.store.driver.impl.StateStoreFileImpl * StateStoreFileImpl} + * <li>FileSystem {@link + * org.apache.hadoop.hdfs.server.federation.store.driver.impl.StateStoreFileSystemImpl + * StateStoreFileSystemImpl} Review Comment: I think it might be better to do it like you do, but from a code perspective, these names correspond better to Java classes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org