[ https://issues.apache.org/jira/browse/HADOOP-18860?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17758169#comment-17758169 ]
ASF GitHub Bot commented on HADOOP-18860: ----------------------------------------- steveloughran commented on code in PR #5977: URL: https://github.com/apache/hadoop/pull/5977#discussion_r1303333169 ########## hadoop-hdfs-project/hadoop-hdfs-rbf/pom.xml: ########## @@ -177,6 +177,11 @@ https://maven.apache.org/xsd/maven-4.0.0.xsd"> <artifactId>junit-jupiter-params</artifactId> <scope>test</scope> </dependency> + <dependency> Review Comment: nit: make the indentation consistent with the others ########## hadoop-project/pom.xml: ########## @@ -1303,7 +1306,20 @@ <dependency> <groupId>org.mockito</groupId> <artifactId>mockito-core</artifactId> - <version>2.28.2</version> + <version>${mockito.version}</version> Review Comment: does it matter that mockito-all is a completely different version from the old or new version of mockito core? > Upgrade mockito to 4.11.0 > ------------------------- > > Key: HADOOP-18860 > URL: https://issues.apache.org/jira/browse/HADOOP-18860 > Project: Hadoop Common > Issue Type: Improvement > Components: build > Affects Versions: 3.3.6 > Reporter: Anmol Asrani > Assignee: Anmol Asrani > Priority: Major > Labels: pull-request-available > > Upgrading mockito in hadoop-project -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org