[
https://issues.apache.org/jira/browse/HADOOP-18845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17758180#comment-17758180
]
ASF GitHub Bot commented on HADOOP-18845:
-----------------------------------------
steveloughran commented on code in PR #5948:
URL: https://github.com/apache/hadoop/pull/5948#discussion_r1303370942
##########
hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/ITestS3AConfiguration.java:
##########
@@ -511,6 +513,34 @@ public void testConfOptionPropagationToFS() throws
Exception {
assertOptionEquals(updated, "fs.s3a.propagation", "propagated");
}
+ @Test(timeout = 10_000L)
+ public void testConnectTtlPropagation() throws Exception {
+ Configuration config = new Configuration();
+ ClientConfiguration awsConf = new ClientConfiguration();
+ initConnectionSettings(config, awsConf);
+ Assertions.assertThat(awsConf.getConnectionTTL())
+ .describedAs(String.format("connection ttl should be set to
default value as" +
Review Comment:
you don't need to use string.format; described as does it anyway
```
describedAs("should be set to %s", value)
```
##########
hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/ITestS3AConfiguration.java:
##########
@@ -511,6 +513,34 @@ public void testConfOptionPropagationToFS() throws
Exception {
assertOptionEquals(updated, "fs.s3a.propagation", "propagated");
}
+ @Test(timeout = 10_000L)
+ public void testConnectTtlPropagation() throws Exception {
+ Configuration config = new Configuration();
+ ClientConfiguration awsConf = new ClientConfiguration();
+ initConnectionSettings(config, awsConf);
+ Assertions.assertThat(awsConf.getConnectionTTL())
+ .describedAs(String.format("connection ttl should be set to
default value as" +
+ " %s is not set", CONNECTION_TTL))
+ .isEqualTo(DEFAULT_CONNECTION_TTL);
+ long connectionTtlTestVal = 1000;
+ config.setLong(CONNECTION_TTL, connectionTtlTestVal);
+ initConnectionSettings(config, awsConf);
+ Assertions.assertThat(awsConf.getConnectionTTL())
+ .describedAs(String.format("%s not propagated to aws conf",
CONNECTION_TTL))
Review Comment:
same
##########
hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/ITestS3AConfiguration.java:
##########
@@ -511,6 +513,34 @@ public void testConfOptionPropagationToFS() throws
Exception {
assertOptionEquals(updated, "fs.s3a.propagation", "propagated");
}
+ @Test(timeout = 10_000L)
+ public void testConnectTtlPropagation() throws Exception {
+ Configuration config = new Configuration();
+ ClientConfiguration awsConf = new ClientConfiguration();
+ initConnectionSettings(config, awsConf);
+ Assertions.assertThat(awsConf.getConnectionTTL())
+ .describedAs(String.format("connection ttl should be set to
default value as" +
+ " %s is not set", CONNECTION_TTL))
+ .isEqualTo(DEFAULT_CONNECTION_TTL);
+ long connectionTtlTestVal = 1000;
+ config.setLong(CONNECTION_TTL, connectionTtlTestVal);
+ initConnectionSettings(config, awsConf);
+ Assertions.assertThat(awsConf.getConnectionTTL())
+ .describedAs(String.format("%s not propagated to aws conf",
CONNECTION_TTL))
+ .isEqualTo(connectionTtlTestVal);
+
+ long connectionTtlTestVal1 = -1;
+ config.setLong(CONNECTION_TTL, connectionTtlTestVal1);
+ initConnectionSettings(config, awsConf);
+ Assertions.assertThat(awsConf.getConnectionTTL())
Review Comment:
same
##########
hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/ITestS3AConfiguration.java:
##########
@@ -511,6 +513,34 @@ public void testConfOptionPropagationToFS() throws
Exception {
assertOptionEquals(updated, "fs.s3a.propagation", "propagated");
}
+ @Test(timeout = 10_000L)
+ public void testConnectTtlPropagation() throws Exception {
+ Configuration config = new Configuration();
Review Comment:
or create a configuration with "false" so it is completely empty
> Add ability to configure ConnectionTTL of http connections while creating S3
> Client.
> ------------------------------------------------------------------------------------
>
> Key: HADOOP-18845
> URL: https://issues.apache.org/jira/browse/HADOOP-18845
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs/s3
> Affects Versions: 3.3.6
> Reporter: Mukund Thakur
> Assignee: Mukund Thakur
> Priority: Major
> Labels: pull-request-available
> Fix For: 3.3.9
>
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
