steveloughran commented on code in PR #5977: URL: https://github.com/apache/hadoop/pull/5977#discussion_r1304033879
########## hadoop-hdfs-project/hadoop-hdfs-rbf/pom.xml: ########## @@ -177,11 +177,6 @@ https://maven.apache.org/xsd/maven-4.0.0.xsd";> <artifactId>junit-jupiter-params</artifactId> <scope>test</scope> </dependency> - <dependency> Review Comment: sorry, i meant "align the elements with the ones above" now, is this going to be needed or is it coming down from the other dependencies anyway (which I would expect). we will find out from the result of the build; if all compiles then mockito core is pulled in by mockito. we've been burned a few times by people (myself included) not realising that when a -test jar is pulled in by another module, h of the test jars dependencies are transitively picked up. this has made rollout of assertJ harder than we'd like. Let's see what happens here -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
