dannytbecker commented on code in PR #6018:
URL: https://github.com/apache/hadoop/pull/6018#discussion_r1315188643
##########
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/ha/BootstrapStandby.java:
##########
@@ -199,28 +202,36 @@ private int doRun() throws IOException {
return ERR_CODE_FAILED_CONNECT;
}
- if (!checkLayoutVersion(nsInfo)) {
- LOG.error("Layout version on remote node (" + nsInfo.getLayoutVersion()
- + ") does not match " + "this node's layout version ("
- + HdfsServerConstants.NAMENODE_LAYOUT_VERSION + ")");
+ if (!checkLayoutVersion(nsInfo, isRollingUpgrade)) {
+ String msg = isRollingUpgrade ? "Layout version on remote node in
rolling"
Review Comment:
Added an if-else with the logger to make it more readable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
