simbadzina commented on code in PR #6013:
URL: https://github.com/apache/hadoop/pull/6013#discussion_r1316761156
##########
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java:
##########
@@ -1161,11 +1163,17 @@ private void stopAtException(Exception e){
}
}
- protected HAState createHAState(StartupOption startOpt) {
+ protected HAState createHAState(Configuration conf) {
+ StartupOption startOpt = getStartupOption(conf);
if (!haEnabled || startOpt == StartupOption.UPGRADE
|| startOpt == StartupOption.UPGRADEONLY) {
Review Comment:
Ok, then the code LGTM.
Where can I find the documentation for the different options? The only
comments I can find are these
https://github.com/apache/hadoop/blob/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java#L1088-L1090
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
