steveloughran commented on PR #4996:
URL: https://github.com/apache/hadoop/pull/4996#issuecomment-1713650781
updated pr tries to address reviews, including building.txt details.
regarding @apurtell's comment about static vs qualified import of
`getRemoteException()` I started to convert, but got fed up with the needless
repetition. So upgraded the RPC invocations to java 8 language level (!!) by
adding a new operation `ipc()` to take a lambda expression and do the
invocation, translating the result
```java
public static <T> T ipc(IpcCall<T> call) throws IOException {
try {
return call.call();
} catch (ServiceException e) {
throw getRemoteException(e);
}
}
```
this lets us have far simpler invocations in the code
```java
status = ipc(() -> rpcProxy.getServiceStatus(NULL_CONTROLLER,
GET_SERVICE_STATUS_REQ));
```
I've done this for hadoop-common; if all are happy then I will do for the
rest of the modules
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
