[
https://issues.apache.org/jira/browse/HADOOP-18890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17765662#comment-17765662
]
ASF GitHub Bot commented on HADOOP-18890:
-----------------------------------------
steveloughran commented on code in PR #6057:
URL: https://github.com/apache/hadoop/pull/6057#discussion_r1327358545
##########
hadoop-project/pom.xml:
##########
@@ -220,62 +218,6 @@
<dependencyManagement>
<dependencies>
- <dependency>
Review Comment:
this should be reinstated with the new exclusions; then the test
declarations don't need changing.
##########
hadoop-common-project/hadoop-common/pom.xml:
##########
@@ -391,11 +391,19 @@
<dependency>
<groupId>com.squareup.okhttp3</groupId>
<artifactId>mockwebserver</artifactId>
+ <version>${okhttp3.version}</version>
Review Comment:
prefer hadoop-project retains the declaration, but now with all the
excludes. the modules should get the exclusions automatically, shouldn't they?
> remove okhttp usage
> -------------------
>
> Key: HADOOP-18890
> URL: https://issues.apache.org/jira/browse/HADOOP-18890
> Project: Hadoop Common
> Issue Type: Bug
> Components: common
> Reporter: PJ Fanning
> Priority: Major
> Labels: pull-request-available
>
> * relates to HADOOP-18496
> * simplifies the dependencies if hadoop doesn't use multiple 3rd party libs
> to make http calls
> * okhttp brings in other dependencies like the kotlin runtime
> * hadoop already uses apache httpclient in some places
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
