saxenapranav commented on code in PR #6025:
URL: https://github.com/apache/hadoop/pull/6025#discussion_r1328597522
##########
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azure/StorageInterfaceImpl.java:
##########
@@ -435,6 +456,24 @@ public void startCopyFromBlob(CloudBlobWrapper sourceBlob,
BlobRequestOptions op
null, dstAccessCondition, options, opContext);
}
+ @Override
+ public void startCopyFromBlob(CloudBlobWrapper sourceBlob,
BlobRequestOptions options,
+ OperationContext opContext, boolean
overwriteDestination, String eTag)
+ throws StorageException, URISyntaxException {
+ AccessCondition dstAccessCondition =
+ overwriteDestination
+ ? null
+ : AccessCondition.generateIfNotExistsCondition();
+ if (dstAccessCondition != null) {
Review Comment:
Checked in which flow? etag is a field in the method, and can be null. I am
suggesting we do not call SDK's setifMatch() if etag with us is null.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
