zhengchenyu commented on PR #6102: URL: https://github.com/apache/hadoop/pull/6102#issuecomment-1741776757
@ayushtkn Thanks for your reply. I think what you said is reasonable. We should try to maintain old behaviour. There are two appender for regular container log: CLA, CRLA. CLA is regular appender. CRLA is roll over appender. Let's analyze the original behavior before HADOOP-18649. | Appender | behaviour | | --- | --- | | CLA | In default, yarn.app.container.log.filesize is 0, means disable cap. If yarn.app.container.log.filesize is greater than 0, the container log will show the limited size log until container is done. | | CRLA | If we use CRLA, yarn.app.container.log.filesize must be greater than 0, will roll over the log when size exceed the limit. | Then let's analyze the original behavior after HADOOP-18649. | Appender | behaviour | | --- | --- | | CLA | same with CRLA | | CRLA | If we use CRLA, yarn.app.container.log.filesize must be greater than 0, will roll over the log when size exceed the limit.| For CRLA, there is no change in behavior. I thought that when using CRLA, yarn.app.container.log.filesize might be 0, so the default value was changed. Util I see https://github.com/apache/hadoop/blob/5f47f091a227ecd1d9b1b375e9c71e01d31a264f/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common/src/main/java/org/apache/hadoop/mapreduce/v2/util/MRApps.java#L635. So I think your are right, there is no need to modify the default value. For CLA, I will replace with org.apache.log4j.FileAppender. But there will be no way to limit the size for FileAppender. And I think there is no need to limit the size for CLA. If we wanna limit the size, we could use CRLA. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
