[ 
https://issues.apache.org/jira/browse/HADOOP-18922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17772602#comment-17772602
 ] 

ASF GitHub Bot commented on HADOOP-18922:
-----------------------------------------

hadoop-yetus commented on PR #6150:
URL: https://github.com/apache/hadoop/pull/6150#issuecomment-1750852334

   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |:----:|----------:|--------:|:--------:|:-------:|
   | +0 :ok: |  reexec  |   0m 29s |  |  Docker mode activated.  |
   |||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  |  No case conflicting files 
found.  |
   | +0 :ok: |  codespell  |   0m  1s |  |  codespell was not available.  |
   | +0 :ok: |  detsecrets  |   0m  1s |  |  detect-secrets was not available.  
|
   | +1 :green_heart: |  @author  |   0m  0s |  |  The patch does not contain 
any @author tags.  |
   | +1 :green_heart: |  test4tests  |   0m  0s |  |  The patch appears to 
include 1 new or modified test files.  |
   |||| _ trunk Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |  31m 50s |  |  trunk passed  |
   | +1 :green_heart: |  compile  |  10m 48s |  |  trunk passed with JDK 
Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04  |
   | +1 :green_heart: |  compile  |   9m 38s |  |  trunk passed with JDK 
Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05  |
   | +1 :green_heart: |  checkstyle  |   0m 51s |  |  trunk passed  |
   | +1 :green_heart: |  mvnsite  |   1m 11s |  |  trunk passed  |
   | +1 :green_heart: |  javadoc  |   0m 59s |  |  trunk passed with JDK 
Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04  |
   | +1 :green_heart: |  javadoc  |   0m 42s |  |  trunk passed with JDK 
Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05  |
   | +1 :green_heart: |  spotbugs  |   1m 41s |  |  trunk passed  |
   | +1 :green_heart: |  shadedclient  |  22m 17s |  |  branch has no errors 
when building and testing our client artifacts.  |
   |||| _ Patch Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   0m 39s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |   9m 46s |  |  the patch passed with JDK 
Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04  |
   | +1 :green_heart: |  javac  |   9m 46s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |   9m 50s |  |  the patch passed with JDK 
Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05  |
   | +1 :green_heart: |  javac  |   9m 50s |  |  the patch passed  |
   | +1 :green_heart: |  blanks  |   0m  0s |  |  The patch has no blanks 
issues.  |
   | +1 :green_heart: |  checkstyle  |   0m 48s |  |  the patch passed  |
   | +1 :green_heart: |  mvnsite  |   1m 10s |  |  the patch passed  |
   | +1 :green_heart: |  javadoc  |   0m 54s |  |  the patch passed with JDK 
Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04  |
   | +1 :green_heart: |  javadoc  |   0m 42s |  |  the patch passed with JDK 
Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05  |
   | +1 :green_heart: |  spotbugs  |   1m 42s |  |  the patch passed  |
   | +1 :green_heart: |  shadedclient  |  26m 30s |  |  patch has no errors 
when building and testing our client artifacts.  |
   |||| _ Other Tests _ |
   | +1 :green_heart: |  unit  |  16m 23s |  |  hadoop-common in the patch 
passed.  |
   | +1 :green_heart: |  asflicense  |   0m 49s |  |  The patch does not 
generate ASF License warnings.  |
   |  |   | 152m 34s |  |  |
   
   
   | Subsystem | Report/Notes |
   |----------:|:-------------|
   | Docker | ClientAPI=1.43 ServerAPI=1.43 base: 
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6150/3/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hadoop/pull/6150 |
   | Optional Tests | dupname asflicense compile javac javadoc mvninstall 
mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets |
   | uname | Linux e37a8037cacb 4.15.0-212-generic #223-Ubuntu SMP Tue May 23 
13:09:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/bin/hadoop.sh |
   | git revision | trunk / 26c2333e3d950fb425b7ef843990bd48b7569884 |
   | Default Java | Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05 |
   | Multi-JDK versions | 
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04 
/usr/lib/jvm/java-8-openjdk-amd64:Private 
Build-1.8.0_382-8u382-ga-1~20.04.1-b05 |
   |  Test Results | 
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6150/3/testReport/ |
   | Max. process+thread count | 1276 (vs. ulimit of 5500) |
   | modules | C: hadoop-common-project/hadoop-common U: 
hadoop-common-project/hadoop-common |
   | Console output | 
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6150/3/console |
   | versions | git=2.25.1 maven=3.6.3 spotbugs=4.2.2 |
   | Powered by | Apache Yetus 0.14.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   




> Race condition in ZKDelegationTokenSecretManager creating znode
> ---------------------------------------------------------------
>
>                 Key: HADOOP-18922
>                 URL: https://issues.apache.org/jira/browse/HADOOP-18922
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: common
>    Affects Versions: 3.4.0, 3.3.6
>            Reporter: Kevin Risden
>            Assignee: Kevin Risden
>            Priority: Major
>              Labels: pull-request-available
>
> When multiple nodes come up at the same time, there is a race condition in 
> ZKDelegationTokenSecretManager since the exists and create check do not mean 
> that the znode was created in the meantime. HADOOP-18452 tried to fix this 
> but the issue still exists.
> A better fix would be to catch the 
> https://zookeeper.apache.org/doc/r3.9.0/apidocs/zookeeper-server/org/apache/zookeeper/KeeperException.NodeExistsException.html
>  if the create fails when the znode already exists. This would eliminate the 
> race condition.
> {code:java}
> 236 ERROR (jetty-launcher-8-thread-1) [n:127.0.0.1:56203_solr] 
> o.a.s.s.CoreContainerProvider Could not start Solr. Check solr/home property 
> and the logs
>           => java.lang.RuntimeException: Could not start class 
> org.apache.hadoop.security.token.delegation.web.DelegationTokenManager$ZKSecretManager:
>  java.io.IOException: Could not create namespace
>       at 
> org.apache.hadoop.security.token.delegation.web.DelegationTokenManager.init(DelegationTokenManager.java:149)
> java.lang.RuntimeException: Could not start class 
> org.apache.hadoop.security.token.delegation.web.DelegationTokenManager$ZKSecretManager:
>  java.io.IOException: Could not create namespace
>       at 
> org.apache.hadoop.security.token.delegation.web.DelegationTokenManager.init(DelegationTokenManager.java:149)
>  ~[hadoop-common-3.3.6.jar:?]
>       at 
> org.apache.hadoop.security.token.delegation.web.DelegationTokenAuthenticationHandler.initTokenManager(DelegationTokenAuthenticationHandler.java:163)
>  ~[hadoop-common-3.3.6.jar:?]
>       at 
> org.apache.hadoop.security.token.delegation.web.DelegationTokenAuthenticationHandler.init(DelegationTokenAuthenticationHandler.java:131)
>  ~[hadoop-common-3.3.6.jar:?]
>       at 
> org.apache.hadoop.security.authentication.server.AuthenticationFilter.initializeAuthHandler(AuthenticationFilter.java:194)
>  ~[hadoop-auth-3.3.6.jar:?]
>       at 
> org.apache.hadoop.security.token.delegation.web.DelegationTokenAuthenticationFilter.initializeAuthHandler(DelegationTokenAuthenticationFilter.java:215)
>  ~[hadoop-common-3.3.6.jar:?]
>       at 
> org.apache.solr.security.hadoop.HadoopAuthFilter.initializeAuthHandler(HadoopAuthFilter.java:124)
>  ~[main/:?]
>       at 
> org.apache.hadoop.security.authentication.server.AuthenticationFilter.init(AuthenticationFilter.java:180)
>  ~[hadoop-auth-3.3.6.jar:?]
>       at 
> org.apache.hadoop.security.token.delegation.web.DelegationTokenAuthenticationFilter.init(DelegationTokenAuthenticationFilter.java:181)
>  ~[hadoop-common-3.3.6.jar:?]
>       at 
> org.apache.solr.security.hadoop.HadoopAuthFilter.init(HadoopAuthFilter.java:75)
>  ~[main/:?]
>       at 
> org.apache.solr.security.hadoop.HadoopAuthPlugin.init(HadoopAuthPlugin.java:135)
>  ~[main/:?]
>       at 
> org.apache.solr.core.CoreContainer.initializeAuthenticationPlugin(CoreContainer.java:569)
>  ~[solr-core-10.0.0-SNAPSHOT.jar:10.0.0-SNAPSHOT 
> a3945a2c3710b1a355abdea7a2e63b5353ad0723 [snapshot build, details omitted]]
>       at 
> org.apache.solr.core.CoreContainer.reloadSecurityProperties(CoreContainer.java:1185)
>  ~[solr-core-10.0.0-SNAPSHOT.jar:10.0.0-SNAPSHOT 
> a3945a2c3710b1a355abdea7a2e63b5353ad0723 [snapshot build, details omitted]]
>       at 
> org.apache.solr.core.CoreContainer.loadInternal(CoreContainer.java:854) 
> ~[solr-core-10.0.0-SNAPSHOT.jar:10.0.0-SNAPSHOT 
> a3945a2c3710b1a355abdea7a2e63b5353ad0723 [snapshot build, details omitted]]
>       at org.apache.solr.core.CoreContainer.load(CoreContainer.java:763) 
> ~[solr-core-10.0.0-SNAPSHOT.jar:10.0.0-SNAPSHOT 
> a3945a2c3710b1a355abdea7a2e63b5353ad0723 [snapshot build, details omitted]]
>       at 
> org.apache.solr.servlet.CoreContainerProvider.createCoreContainer(CoreContainerProvider.java:427)
>  ~[solr-core-10.0.0-SNAPSHOT.jar:10.0.0-SNAPSHOT 
> a3945a2c3710b1a355abdea7a2e63b5353ad0723 [snapshot build, details omitted]]
>       at 
> org.apache.solr.servlet.CoreContainerProvider.init(CoreContainerProvider.java:246)
>  [solr-core-10.0.0-SNAPSHOT.jar:10.0.0-SNAPSHOT 
> a3945a2c3710b1a355abdea7a2e63b5353ad0723 [snapshot build, details omitted]]
>       at 
> org.apache.solr.embedded.JettySolrRunner$1.lifeCycleStarted(JettySolrRunner.java:405)
>  [solr-test-framework-10.0.0-SNAPSHOT.jar:10.0.0-SNAPSHOT 
> a3945a2c3710b1a355abdea7a2e63b5353ad0723 [snapshot build, details omitted]]
>       at 
> org.eclipse.jetty.util.component.AbstractLifeCycle.setStarted(AbstractLifeCycle.java:253)
>  [jetty-util-10.0.16.jar:10.0.16]
>       at 
> org.eclipse.jetty.util.component.AbstractLifeCycle.start(AbstractLifeCycle.java:94)
>  [jetty-util-10.0.16.jar:10.0.16]
>       at 
> org.apache.solr.embedded.JettySolrRunner.retryOnPortBindFailure(JettySolrRunner.java:614)
>  [solr-test-framework-10.0.0-SNAPSHOT.jar:10.0.0-SNAPSHOT 
> a3945a2c3710b1a355abdea7a2e63b5353ad0723 [snapshot build, details omitted]]
>       at 
> org.apache.solr.embedded.JettySolrRunner.start(JettySolrRunner.java:552) 
> [solr-test-framework-10.0.0-SNAPSHOT.jar:10.0.0-SNAPSHOT 
> a3945a2c3710b1a355abdea7a2e63b5353ad0723 [snapshot build, details omitted]]
>       at 
> org.apache.solr.embedded.JettySolrRunner.start(JettySolrRunner.java:523) 
> [solr-test-framework-10.0.0-SNAPSHOT.jar:10.0.0-SNAPSHOT 
> a3945a2c3710b1a355abdea7a2e63b5353ad0723 [snapshot build, details omitted]]
>       at 
> org.apache.solr.cloud.MiniSolrCloudCluster.startJettySolrRunner(MiniSolrCloudCluster.java:508)
>  [solr-test-framework-10.0.0-SNAPSHOT.jar:10.0.0-SNAPSHOT 
> a3945a2c3710b1a355abdea7a2e63b5353ad0723 [snapshot build, details omitted]]
>       at 
> org.apache.solr.cloud.MiniSolrCloudCluster.lambda$new$0(MiniSolrCloudCluster.java:320)
>  [solr-test-framework-10.0.0-SNAPSHOT.jar:10.0.0-SNAPSHOT 
> a3945a2c3710b1a355abdea7a2e63b5353ad0723 [snapshot build, details omitted]]
>       at java.util.concurrent.FutureTask.run(FutureTask.java:264) [?:?]
>       at 
> org.apache.solr.common.util.ExecutorUtil$MDCAwareThreadPoolExecutor.lambda$execute$0(ExecutorUtil.java:294)
>  [solr-solrj-10.0.0-SNAPSHOT.jar:10.0.0-SNAPSHOT 
> a3945a2c3710b1a355abdea7a2e63b5353ad0723 [snapshot build, details omitted]]
>       at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136)
>  [?:?]
>       at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635)
>  [?:?]
>       at java.lang.Thread.run(Thread.java:833) [?:?]
> Caused by: java.io.IOException: Could not create namespace
>       at 
> org.apache.hadoop.security.token.delegation.ZKDelegationTokenSecretManager.startThreads(ZKDelegationTokenSecretManager.java:275)
>  ~[hadoop-common-3.3.6.jar:?]
>       at 
> org.apache.hadoop.security.token.delegation.web.DelegationTokenManager.init(DelegationTokenManager.java:146)
>  ~[hadoop-common-3.3.6.jar:?]
>       ... 28 more
> Caused by: org.apache.zookeeper.KeeperException$NodeExistsException: 
> KeeperErrorCode = NodeExists for /solr/security/zkdtsm/ZKDTSMRoot
>       at 
> org.apache.zookeeper.KeeperException.create(KeeperException.java:125) 
> ~[zookeeper-3.9.0.jar:3.9.0]
>       at org.apache.zookeeper.KeeperException.create(KeeperException.java:53) 
> ~[zookeeper-3.9.0.jar:3.9.0]
>       at org.apache.zookeeper.ZooKeeper.create(ZooKeeper.java:1450) 
> ~[zookeeper-3.9.0.jar:3.9.0]
>       at 
> org.apache.curator.framework.imps.CreateBuilderImpl$18.call(CreateBuilderImpl.java:1223)
>  ~[curator-framework-5.2.0.jar:5.2.0]
>       at 
> org.apache.curator.framework.imps.CreateBuilderImpl$18.call(CreateBuilderImpl.java:1193)
>  ~[curator-framework-5.2.0.jar:5.2.0]
>       at org.apache.curator.RetryLoop.callWithRetry(RetryLoop.java:93) 
> ~[curator-client-5.2.0.jar:?]
>       at 
> org.apache.curator.framework.imps.CreateBuilderImpl.pathInForeground(CreateBuilderImpl.java:1190)
>  ~[curator-framework-5.2.0.jar:5.2.0]
>       at 
> org.apache.curator.framework.imps.CreateBuilderImpl.protectedPathInForeground(CreateBuilderImpl.java:605)
>  ~[curator-framework-5.2.0.jar:5.2.0]
>       at 
> org.apache.curator.framework.imps.CreateBuilderImpl.forPath(CreateBuilderImpl.java:595)
>  ~[curator-framework-5.2.0.jar:5.2.0]
>       at 
> org.apache.curator.framework.imps.CreateBuilderImpl.forPath(CreateBuilderImpl.java:573)
>  ~[curator-framework-5.2.0.jar:5.2.0]
>       at 
> org.apache.curator.framework.imps.CreateBuilderImpl$4.forPath(CreateBuilderImpl.java:461)
>  ~[curator-framework-5.2.0.jar:5.2.0]
>       at 
> org.apache.curator.framework.imps.CreateBuilderImpl$4.forPath(CreateBuilderImpl.java:391)
>  ~[curator-framework-5.2.0.jar:5.2.0]
>       at 
> org.apache.hadoop.security.token.delegation.ZKDelegationTokenSecretManager.startThreads(ZKDelegationTokenSecretManager.java:272)
>  ~[hadoop-common-3.3.6.jar:?]
>       at 
> org.apache.hadoop.security.token.delegation.web.DelegationTokenManager.init(DelegationTokenManager.java:146)
>  ~[hadoop-common-3.3.6.jar:?]
>       ... 28 more
> {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

Reply via email to