steveloughran opened a new pull request, #6202: URL: https://github.com/apache/hadoop/pull/6202
- Enable async refresh in inner credential provider. - Store provider instance in a field; use synchronized() call to handle failure and switch from container to EC2 provider. - Close inner provider in close(); - use ErrorTranslation to extract any IOE at base on stack - rename maybeExtractNetworkException to maybeExtractIOException (as requested in review of third party support) - test for error translation going through UncheckedIOException - TestIAMInstanceCredentialsProvider to test fallback process TestIAMInstanceCredentialsProvider is tricky as there are different test outcomes 1. In EC2: credentials resolved. Assert comes with a key. 2. Not in EC2: network error trying to talk to the service. Assert wrapped exception is an IOE. 3. IMDS resolution disabled by env var/sysprop. Expect the message to contain the text from the SDK The test is potentially brittle; there may be followups. ### How was this patch tested? * Tested with `AWS_EC2_METADATA_DISABLED=true` (my default) and with it unset. * Not tested in EC2/k8s yet, that will be the success path. ### For code changes: - [ ] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')? - [ ] Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the `LICENSE`, `LICENSE-binary`, `NOTICE-binary` files? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
