K0K0V0K commented on PR #6229: URL: https://github.com/apache/hadoop/pull/6229#issuecomment-1784860320
Check style says ``` ./hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/jmx/JMXJsonServlet.java:146: protected transient boolean nanFilter;:31: Variable 'nanFilter' must be private and have accessor methods. [VisibilityModifier] ``` but I think we should rather keep it like this cause the other variables like this neither have getter / setter. ( But if someone disagree with this i can add the getter/setter) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
