[ https://issues.apache.org/jira/browse/HADOOP-18958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17781594#comment-17781594 ]
ASF GitHub Bot commented on HADOOP-18958: ----------------------------------------- xinglin commented on code in PR #6234: URL: https://github.com/apache/hadoop/pull/6234#discussion_r1378397971 ########## hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/UserGroupInformation.java: ########## @@ -1849,8 +1849,8 @@ protected Subject getSubject() { @InterfaceStability.Evolving public <T> T doAs(PrivilegedAction<T> action) { if (LOG.isDebugEnabled()) { - LOG.debug("PrivilegedAction [as: {}][action: {}]", this, action, - new Exception()); + LOG.debug("PrivilegedAction [as: {}][action: {}][from: {}]", this, action, + Thread.currentThread().getStackTrace()[2]); Review Comment: I guess you don't have to convince me in order to merge this PR. You can get another reviewer/committer to review your PR and if they think this is an improvement, we can still get your PR merged. > UserGroupInformation debug log improve > -------------------------------------- > > Key: HADOOP-18958 > URL: https://issues.apache.org/jira/browse/HADOOP-18958 > Project: Hadoop Common > Issue Type: Improvement > Components: common > Affects Versions: 3.3.5, 3.3.3, 3.3.4 > Reporter: wangzhihui > Priority: Minor > Labels: pull-request-available > Fix For: 3.3.4 > > Attachments: 20231029-122825-1.jpeg, 20231029-122825.jpeg, > 20231030-143525.jpeg, image-2023-10-29-09-47-56-489.png, > image-2023-10-30-14-35-11-161.png > > Original Estimate: 1h > Remaining Estimate: 1h > > Using “new Exception( )” to print the call stack of "doAs Method " in > the UserGroupInformation class. Using this way will print meaningless > Exception information and too many call stacks, This is not conducive to > troubleshooting > *example:* > !20231029-122825.jpeg|width=991,height=548! > > *improved result* : > > !image-2023-10-29-09-47-56-489.png|width=1099,height=156! > !20231030-143525.jpeg|width=572,height=674! -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org