[ 
https://issues.apache.org/jira/browse/HADOOP-18487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17782544#comment-17782544
 ] 

ASF GitHub Bot commented on HADOOP-18487:
-----------------------------------------

steveloughran commented on PR #6185:
URL: https://github.com/apache/hadoop/pull/6185#issuecomment-1792335963

   oh, i get it. I'd updated the BUILDING.txt in the wrong branch, so even 
though it was pushed up it had gone to the branch on the earlier pr. lets see 
what yetus says and merge it




> Make protobuf 2.5 an optional runtime dependency.
> -------------------------------------------------
>
>                 Key: HADOOP-18487
>                 URL: https://issues.apache.org/jira/browse/HADOOP-18487
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: build, ipc
>    Affects Versions: 3.3.4
>            Reporter: Steve Loughran
>            Assignee: Steve Loughran
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 3.4.0
>
>
> uses of protobuf 2.5 and RpcEnginej have been deprecated since 3.3.0 in 
> HADOOP-17046
> while still keeping those files around (for a long time...), how about we 
> make the protobuf 2.5.0 export off hadoop common and hadoop-hdfs *provided*, 
> rather than *compile*
> that way, if apps want it for their own apis, they have to explicitly ask for 
> it, but at least our own scans don't break.
> i have no idea what will happen to the rest of the stack at this point, it 
> will be "interesting" to see



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

Reply via email to