slfan1989 commented on code in PR #6260:
URL: https://github.com/apache/hadoop/pull/6260#discussion_r1386482442


##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/uam/UnmanagedApplicationManager.java:
##########
@@ -431,6 +431,7 @@ private void submitUnmanagedApp(ApplicationId appId) throws 
YarnException, IOExc
     context.setResource(resource);
     context.setAMContainerSpec(amContainer);
     if (applicationSubmissionContext != null) {
+      
context.setApplicationName(applicationSubmissionContext.getApplicationName());

Review Comment:
   This is a good idea, but I'm still a little worried. The initial decision 
not to assign  application name was to quickly differentiate whether the task 
originated from a different sub-cluster. If we were to assign a name, it might 
make it more challenging to discern if the task belongs to another sub-cluster. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

Reply via email to