[
https://issues.apache.org/jira/browse/HADOOP-8202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13236908#comment-13236908
]
Aaron T. Myers commented on HADOOP-8202:
----------------------------------------
Hi Hari, a few comments:
# "c = (Closeable) Proxy.getInvocationHandler(proxy);" - this could potentially
cause an uncaught ClassCastException, if the InvocationHandler itself doesn't
implement Closeable.
# Given the above, the error message at the bottom of the message should
perhaps also include "or invocation handler does not implement Closeable"
# 'LOG.error(... + "or does not provide invocation handler for proxy class"' -
should put a space after "class"
# 'LOG.error("Cannot close proxy since it is null ");' - unnecessary whitespace
at the end of the string.
# Seems like it shouldn't be too tough to write a test for this with some mock
objects.
# Rather than have a single catch-all error message at the bottom, and return
early to avoid it, I think it'd be better to only ever log a single error, and
include the relevant information which caused the failure to close the proxy in
that log message.
Also:
bq. Does this fix the exception that you observed in the test, where proxy was
not stopped?
What exception? In what test?
> stopproxy() is not closing the proxies correctly
> ------------------------------------------------
>
> Key: HADOOP-8202
> URL: https://issues.apache.org/jira/browse/HADOOP-8202
> Project: Hadoop Common
> Issue Type: Bug
> Components: ipc
> Affects Versions: 0.24.0
> Reporter: Hari Mankude
> Assignee: Hari Mankude
> Priority: Minor
> Attachments: HADOOP-8202.patch, HADOOP-8202.patch
>
>
> I was running testbackupnode and noticed that NNprotocol proxy was not being
> closed. Talked with Suresh and he observed that most of the protocols do not
> implement ProtocolTranslator and hence the logic in stopproxy() does not
> work. Instead, since all of them are closeable, Suresh suggested that
> closeable property should be used at close.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
