steveloughran commented on code in PR #6164:
URL: https://github.com/apache/hadoop/pull/6164#discussion_r1394114015
##########
hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/S3AUtils.java:
##########
@@ -170,6 +171,15 @@ public static IOException translateException(@Nullable
String operation,
operation,
StringUtils.isNotEmpty(path)? (" on " + path) : "",
exception);
+
+ // Exceptions from encryption client are wrapped in
S3EncryptionClientException, so unwrap.
+ if (exception instanceof S3EncryptionClientException) {
Review Comment:
this will make the new library mandatory. need some more work here, such as
simply looking a class details of nested exception. should also go into
`org.apache.hadoop.fs.s3a.impl.ErrorTranslation`
with a unit test
##########
hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/impl/AWSClientConfig.java:
##########
@@ -32,12 +32,12 @@
import software.amazon.awssdk.http.apache.ApacheHttpClient;
import software.amazon.awssdk.http.apache.ProxyConfiguration;
import software.amazon.awssdk.http.nio.netty.NettyNioAsyncHttpClient;
+import
software.amazon.awssdk.thirdparty.org.apache.http.client.utils.URIBuilder;
Review Comment:
this stops people building docker images with more minimal packaging than
the bundle.jar; something we had to fix before.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
