saxenapranav commented on code in PR #6270: URL: https://github.com/apache/hadoop/pull/6270#discussion_r1402009495
########## hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/services/ITestAbfsInputStreamReadFooter.java: ########## @@ -387,8 +374,72 @@ private void testPartialReadWithSomeData(final FileSystem fs, } } - private AzureBlobFileSystem getFileSystem(boolean optimizeFooterRead, - int fileSize) throws IOException { + @Test + public void testFooterReadBufferSizeConfiguration() throws Exception { + final AzureBlobFileSystem fs = getFileSystem(); + Path testFilePath = createPathAndFileWithContent(fs, 0, ONE_KB); + final int footerReadBufferSizeConfig = 4 * ONE_KB; + final int footerReadBufferSizeBuilder = 5 * ONE_KB; + + // Verify that default value is used if nothing is set explicitly + FSDataInputStream iStream = fs.open(testFilePath); + verifyConfigValueInStream(iStream, DEFAULT_FOOTER_READ_BUFFER_SIZE); Review Comment: there should be a check if there is a config in test-config. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org