[ https://issues.apache.org/jira/browse/HADOOP-18971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17788807#comment-17788807 ]
ASF GitHub Bot commented on HADOOP-18971: ----------------------------------------- hadoop-yetus commented on PR #6270: URL: https://github.com/apache/hadoop/pull/6270#issuecomment-1822931221 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |:----:|----------:|--------:|:--------:|:-------:| | +0 :ok: | reexec | 0m 46s | | Docker mode activated. | |||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | | No case conflicting files found. | | +0 :ok: | codespell | 0m 0s | | codespell was not available. | | +0 :ok: | detsecrets | 0m 0s | | detect-secrets was not available. | | +1 :green_heart: | @author | 0m 0s | | The patch does not contain any @author tags. | | +1 :green_heart: | test4tests | 0m 0s | | The patch appears to include 3 new or modified test files. | |||| _ trunk Compile Tests _ | | +1 :green_heart: | mvninstall | 47m 19s | | trunk passed | | +1 :green_heart: | compile | 0m 36s | | trunk passed with JDK Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04 | | +1 :green_heart: | compile | 0m 34s | | trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05 | | +1 :green_heart: | checkstyle | 0m 29s | | trunk passed | | +1 :green_heart: | mvnsite | 0m 38s | | trunk passed | | +1 :green_heart: | javadoc | 0m 36s | | trunk passed with JDK Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04 | | +1 :green_heart: | javadoc | 0m 32s | | trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05 | | +1 :green_heart: | spotbugs | 1m 3s | | trunk passed | | +1 :green_heart: | shadedclient | 37m 28s | | branch has no errors when building and testing our client artifacts. | |||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 0m 28s | | the patch passed | | +1 :green_heart: | compile | 0m 29s | | the patch passed with JDK Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04 | | +1 :green_heart: | javac | 0m 29s | | the patch passed | | +1 :green_heart: | compile | 0m 26s | | the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05 | | +1 :green_heart: | javac | 0m 26s | | the patch passed | | +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks issues. | | -0 :warning: | checkstyle | 0m 18s | [/results-checkstyle-hadoop-tools_hadoop-azure.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6270/6/artifact/out/results-checkstyle-hadoop-tools_hadoop-azure.txt) | hadoop-tools/hadoop-azure: The patch generated 9 new + 2 unchanged - 0 fixed = 11 total (was 2) | | +1 :green_heart: | mvnsite | 0m 29s | | the patch passed | | +1 :green_heart: | javadoc | 0m 25s | | the patch passed with JDK Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04 | | +1 :green_heart: | javadoc | 0m 24s | | the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05 | | +1 :green_heart: | spotbugs | 1m 1s | | the patch passed | | +1 :green_heart: | shadedclient | 38m 17s | | patch has no errors when building and testing our client artifacts. | |||| _ Other Tests _ | | +1 :green_heart: | unit | 2m 12s | | hadoop-azure in the patch passed. | | +1 :green_heart: | asflicense | 0m 33s | | The patch does not generate ASF License warnings. | | | | 138m 28s | | | | Subsystem | Report/Notes | |----------:|:-------------| | Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6270/6/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hadoop/pull/6270 | | Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets | | uname | Linux c1238a49b4ab 5.15.0-88-generic #98-Ubuntu SMP Mon Oct 2 15:18:56 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/bin/hadoop.sh | | git revision | trunk / a7597ed0b5e281be9116d4714960f62e4ed0c306 | | Default Java | Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05 | | Multi-JDK versions | /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05 | | Test Results | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6270/6/testReport/ | | Max. process+thread count | 579 (vs. ulimit of 5500) | | modules | C: hadoop-tools/hadoop-azure U: hadoop-tools/hadoop-azure | | Console output | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6270/6/console | | versions | git=2.25.1 maven=3.6.3 spotbugs=4.2.2 | | Powered by | Apache Yetus 0.14.0 https://yetus.apache.org | This message was automatically generated. > ABFS: Enable Footer Read Optimizations with Appropriate Footer Read Buffer > Size > ------------------------------------------------------------------------------- > > Key: HADOOP-18971 > URL: https://issues.apache.org/jira/browse/HADOOP-18971 > Project: Hadoop Common > Issue Type: Sub-task > Components: fs/azure > Affects Versions: 3.3.6 > Reporter: Anuj Modi > Assignee: Anuj Modi > Priority: Major > Labels: pull-request-available > > Footer Read Optimization was introduced to Hadoop azure in this Jira: > https://issues.apache.org/jira/browse/HADOOP-17347 > and was kept disabled by default. > This PR is to enable footer reads by default based on the results of analysis > performed as below: > In our scale workload analysis, it was found that workloads working with > Parquet (or for that matter OCR etc.) have a lot of footer reads. Footer > reads here refers to the read operations done by workload to get the metadata > of the parquet file which is required to understand where the actual data > resides in the parquet. > This whole process takes place in 3 steps: > # Workload reads the last 8 bytes of parquet file to get the offset and size > of the metadata which is present just above these 8 bytes. > # Using that offset, workload reads the metadata to get the exact offset and > length of data which it wants to read. > # Workload performs the final read operation to get the data it wants to use > for its purpose. > Here the first two steps are metadata reads that can be combined into a > single footer read. When workload tries to read certain last few bytes of > data (let's say this value is footer size), driver will intelligently read > some extra bytes above the footer size to cater to the next read which is > going to come. > Q. What is the footer size of file? > A: 16KB. Any read request trying to get the data within last 16KB of the file > will qualify for whole footer read. This value is enough to cater to all > types of files including parquet, OCR, etc. > Q. What is the buffer size to read when reading the footer? > A. Let's call this footer read buffer size. Prior to this PR footer read > buffer size was same as read buffer size (default 4MB). It was found that for > most of the workload required footer size was only 256KB. i.e. For almost all > parquet files metadata for that file was found to be within last 256KBs. > Keeping this in mind it does not make sense to read whole buffer length of > 4MB as a part of footer read. Moreover, reading larger data than require > incur additional costs in terms of server and network latencies. Based on > this and extensive experimentation it was observed that footer read buffer > size of 512KB is ideal for almost all the workloads running on parquet, OCR, > etc. > Following configuration was introduced to configure the footer read buffer > size: > {*}fs.azure.footer.read.request.size{*}: default 512 KB. > *Quantitative Stats:* For a workload running on parquet files the number of > read requests got reduced by 2.3M down from 20M. That means around 10% > reduction in overall TPS. -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org