[ 
https://issues.apache.org/jira/browse/HADOOP-18959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17792126#comment-17792126
 ] 

ASF GitHub Bot commented on HADOOP-18959:
-----------------------------------------

virajjasani commented on PR #6302:
URL: https://github.com/apache/hadoop/pull/6302#issuecomment-1836418036

   Sounds good, thanks @ahmarsuhail. For branch-3.4, this will be clean 
cherry-pick since it was just cut recently.




> Use builder for prefetch CachingBlockManager
> --------------------------------------------
>
>                 Key: HADOOP-18959
>                 URL: https://issues.apache.org/jira/browse/HADOOP-18959
>             Project: Hadoop Common
>          Issue Type: Sub-task
>            Reporter: Viraj Jasani
>            Assignee: Viraj Jasani
>            Priority: Major
>              Labels: pull-request-available
>
> Some of the recent changes (HADOOP-18399, HADOOP-18291, HADOOP-18829 etc) 
> have added more params for prefetch CachingBlockManager c'tor to process 
> read/write block requests. They have added too many params and more are 
> likely to be introduced later. We should use builder pattern to pass params.
> This would also help consolidating required prefetch params into one single 
> place within S3ACachingInputStream, from scattered locations.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

Reply via email to