xinglin commented on PR #6280: URL: https://github.com/apache/hadoop/pull/6280#issuecomment-1839519151
The key point is if we use UDPClient/server from other module, then it becomes inappropriate to put this under hadoop-common-project/hadoop-nfs module. And if we don't fix it now but build upon this, it would make code harder to maintain and would take more work if we want to fix it in the future. Another example is the key-value Interface/implementation. Right now, YARN uses a key-value store to store some persistent data and they put key-value interface/implementation in YARN module. However, we may look into store persistent k/v pairs too for HDFS. We should move key-value interface/implemention into hadoop-common, rather than adding a dependency on YARN from HDFS. I still remember a lesson I learned from reading John Ousterhout's "a philosophy of software engineering" book: when we make a change to an existing system, we should make the new change such that the new change seems to be designed from the beginning. On the other hand, most of us tend to try minimizing line of changes, which ideally shouldn't not be a concern. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
