TestBoost opened a new pull request, #6346:
URL: https://github.com/apache/hadoop/pull/6346

   <!--
     Thanks for sending a pull request!
       1. If this is your first time, please read our contributor guidelines: 
https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute
       2. Make sure your PR title starts with JIRA issue id, e.g., 
'HADOOP-17799. Your PR title ...'.
   -->
   
   ### Description of PR
   This pull request tries to only create/close the cluster and create the file 
system once in the test class `TestOfflineImageViewerWithStripedBlocks` to 
speed up tests.
   
   There are seven tests in the test class 
`TestOfflineImageViewerWithStripedBlocks`. However, all of them call 
`testFileSize` with the number of bytes and they are not trying to modify the 
file system located in the cluster. They are also not modifying the cluster. 
There is no need to always make the same cluster, create the same file system 
before every test runs and close the cluster after every test runs, which makes 
tests in the test class `TestOfflineImageViewerWithStripedBlocks` run slower.
   
   ### How was this patch tested?
   When run on our own machine, the test runtime for the test class 
`TestOfflineImageViewerWithStripedBlocks` jumps from `8.87 s` to `4.336 s` 
after applying the change.
   
   ### For code changes:
   
   - [ ] Does the title or this PR starts with the corresponding JIRA issue id 
(e.g. 'HADOOP-17799. Your PR title ...')?
   - [ ] Object storage: have the integration tests been executed and the 
endpoint declared according to the connector-specific documentation?
   - [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?
   - [ ] If applicable, have you updated the `LICENSE`, `LICENSE-binary`, 
`NOTICE-binary` files?
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

Reply via email to