ayushtkn commented on code in PR #6402:
URL: https://github.com/apache/hadoop/pull/6402#discussion_r1440357368
##########
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/DebugAdmin.java:
##########
@@ -306,7 +306,7 @@ int run(List<String> args) throws IOException {
new BufferedOutputStream(Files.newOutputStream(srcMeta.toPath()),
smallBufferSize));
BlockMetadataHeader.writeHeader(metaOut, checksum);
- metaOut.close();
+ metaOut.flush();
Review Comment:
I think you got me wrong, only 1 line was required, finally should have
remained, if there is an exception before close, the stream would remain open
otherwise
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
