hfutatzhanghb commented on code in PR #6403:
URL: https://github.com/apache/hadoop/pull/6403#discussion_r1440611536
##########
hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DFSInputStream.java:
##########
@@ -1647,16 +1661,8 @@ public synchronized boolean seekToNewSource(long
targetPos)
if (currentNode == null) {
return seekToBlockSource(targetPos);
}
- boolean markedDead = dfsClient.isDeadNode(this, currentNode);
- addToLocalDeadNodes(currentNode);
Review Comment:
Hi, @KeeProMise. The idea of this PR make sense to me. Leave some comments.
Try to confirm whether we should delete those codes. I think we can not delete
because this will destory dead node detector model. Should be like :
```java
boolean markedDead = dfsClient.isDeadNode(this, currentNode);
addToLocalDeadNodes(currentNode);
if (!markedDead) {
/* remove it from deadNodes. blockSeekTo could have cleared
* deadNodes and added currentNode again. Thats ok. */
removeFromLocalDeadNodes(oldNode);
}
DatanodeInfo newNode = blockSeekTo(targetPos,
Collections.singletonList(currentNode));
if (!currentNode.getDatanodeUuid().equals(newNode.getDatanodeUuid())) {
xxx
}
```
What your opinions?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
